Re: [PATCH] rebase: standardize on $() for command substitution

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 1, 2007, 05:16 UTC
Message-ID: <7vr6jaczps.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <1193892608-31322-1-git-send-email-dpmcgee@gmail.com>

Dan McGee <dpmcgee@gmail.com> writes:

Show 13 quoted lines

> Commit 889a50e909dba5f4416049afc5eeae601fe133bc changed several `` to $()
> format for command substitution, so we should standardize on one format
> for clarity.
> ...
> @@ -203,7 +203,7 @@ do
>  	-s|--s|--st|--str|--stra|--strat|--strate|--strateg|--strategy)
>  		case "$#,$1" in
>  		*,*=*)
> -			strategy=`expr "z$1" : 'z-[^=]*=\(.*\)'` ;;
> +			strategy=$(expr "z$1" : 'z-[^=]*=\(.*\)'` ;)
>  		1,*)
>  			usage ;;
>  		*)

The patch might have meant well, but it is a rather unnecessary code churn without fixing anything and introducing a bug X-<.