git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] builtin-commit: fix --signoff

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 10, 2007, 09:06 UTC
Message-ID
<7vr6iyo4ff.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<Pine.LNX.4.64.0711100548071.4362@racer.site>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 15 quoted lines
>  	if (signoff) {
> ...
> +		strbuf_init(&sob, 0);
> +		strbuf_addstr(&sob, sign_off_header);
> +		strbuf_addstr(&sob, git_committer_info(1));
> +		p = strrchr(sob.buf, '>');
> +		if (p)
> +			strbuf_setlen(&sob, p + 1 - sob.buf);
> +		strbuf_addch(&sob, '\n');
> +
> +		for (i = sb.len - 1; i > 0 && sb.buf[i - 1] != '\n'; i--)
> +			; /* do nothing */
> +		if (prefixcmp(sb.buf + i, sob.buf))
> +			strbuf_addbuf(&sb, &sob);
>  	}
At this point doesn't this leak sob.buf?
Previous: Johannes SchindelinNext: Pierre Habouzit
Message 2 of 5 in “builtin-commit: fix --signoff”
  1. builtin-commit: fix --signoffJohannes Schindelin, Nov 10, 2007
  2. Junio C HamanoNov 10, 2007
  3. Pierre HabouzitNov 10, 2007
  4. Johannes SchindelinNov 10, 2007
  5. builtin-commit: fix --signoffJohannes Schindelin, Nov 10, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.