Re: [PATCH] builtin-commit: fix --signoff
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 15 quoted lines
> if (signoff) {
> ...
> + strbuf_init(&sob, 0);
> + strbuf_addstr(&sob, sign_off_header);
> + strbuf_addstr(&sob, git_committer_info(1));
> + p = strrchr(sob.buf, '>');
> + if (p)
> + strbuf_setlen(&sob, p + 1 - sob.buf);
> + strbuf_addch(&sob, '\n');
> +
> + for (i = sb.len - 1; i > 0 && sb.buf[i - 1] != '\n'; i--)
> + ; /* do nothing */
> + if (prefixcmp(sb.buf + i, sob.buf))
> + strbuf_addbuf(&sb, &sob);
> }At this point doesn't this leak sob.buf?