Re: [PATCH 5/6] archive: allow --exec and --remote without equal sign
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 26, 2008, 00:28 UTC
- Message-ID
- <7vr69hpjyo.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <1216982486-5887-5-git-send-email-rene.scharfe@lsrfire.ath.cx>
Rene Scharfe <rene.scharfe@lsrfire.ath.cx> writes:
Show 27 quoted lines
> Allow "--remote repo" and "--exec cmd" in addition to "--remote=repo" and
> "--exec=cmd" to make their usage consistent with parameters handled by
> parse_options().
>
> Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
> ---
> builtin-archive.c | 20 +++++++++++++++++---
> 1 files changed, 17 insertions(+), 3 deletions(-)
>
> diff --git a/builtin-archive.c b/builtin-archive.c
> index 4dd2716..22445ac 100644
> --- a/builtin-archive.c
> +++ b/builtin-archive.c
> @@ -15,7 +15,7 @@ static int run_remote_archiver(const char *remote, int argc,
> int fd[2], i, len, rv;
> struct child_process *conn;
> const char *exec = "git-upload-archive";
> - int exec_at = 0;
> + int exec_at = 0, exec_value_at = 0;
>
> for (i = 1; i < argc; i++) {
> const char *arg = argv[i];
> @@ -24,7 +24,14 @@ static int run_remote_archiver(const char *remote, int argc,
> die("multiple --exec specified");
> exec = arg + 7;
> exec_at = i;
> - break;Interesting... With this "break", we would have never triggered the multiple --exec error, wouldn't we?
The patch itself looked fine. Thanks.