Re: [PATCH 1/2] clone: Add an option to set up a mirror

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 2, 2008, 18:55 UTC
Message-ID: <7vr697l01j.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <alpine.DEB.1.00.0808011600170.9611@pacific.mpi-cbg.de.mpi-cbg.de>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 8 quoted lines

> The command line
>
> 	$ git clone --mirror $URL
>
> is now a short-hand for
>
> 	$ git clone --bare $URL
> 	$ (cd $(basename $URL) && git remote add --mirror origin $URL)

I think this would be a useful behaviour and I am very tempted to violate the general policy of not taking any new options nor features after -rc1.

I however notice that there are differences bewteen the above sequence and what your code actually does:

 - The "remote add --mirror" sequence tells it to mirror everything, but
   the patch still mirrors only heads;

 - You are not setting up "remote.*.mirror = yes" in the configuration;