git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Showing whitespace on minus lines of diff ouput

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 5, 2010, 06:02 UTC
Message-ID
<7vr5p0kyp0.fsf@alter.siamese.dyndns.org>
In-Reply-To
<7veil0o02z.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
Show 13 quoted lines
> Jay Soffian <jaysoffian@gmail.com> writes:
>
>> The colored diff output is quite helpful to show introductions of whitespace.
>>
>> However, if whitespace has been removed, it's impossible to see in the
>> diff output since whitespace is colorized on '+' lines, but not '-'
>> lines.
>>
>> I'm looking at diff.c, but wow. Can someone more familiar with this
>> file point me toward how I'd make a patch to colorize whitespace on
>> '-' lines as well?
>
> Totally uninterested.  "diff -R" would be enough, wouldn't it?

Actually the reason I don't like the idea to highlight corrected errors was not just because "'diff -R' is enough".

The coloring of whitespace errors are like compiler warnings, at least to me, and giving similar highlighting to corrected ones defeats the purpose by making the output more distracting..

Previous: Jay SoffianNext: Jay Soffian
Message 6 of 7 in “Showing whitespace on minus lines of diff ouput”
  1. Jay SoffianFeb 5, 2010
  2. Jay SoffianFeb 5, 2010
  3. Jay SoffianFeb 5, 2010
  4. Junio C HamanoFeb 5, 2010
  5. Jay SoffianFeb 5, 2010
  6. Junio C HamanoFeb 5, 2010
  7. Jay SoffianFeb 5, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.