git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] {fetch,upload}-pack: allow --depth=0 for infinite depth

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 21, 2010, 00:27 UTC
Message-ID
<7vr5hs95e8.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1282269067-5527-3-git-send-email-pclouds@gmail.com>
Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
Show 24 quoted lines
> diff --git a/Documentation/fetch-options.txt b/Documentation/fetch-options.txt
> index 9333c42..a22d839 100644
> --- a/Documentation/fetch-options.txt
> +++ b/Documentation/fetch-options.txt
> @@ -10,7 +10,8 @@
>  --depth=<depth>::
>  	Deepen the history of a 'shallow' repository created by
>  	`git clone` with `--depth=<depth>` option (see linkgit:git-clone[1])
> -	by the specified number of commits.
> +	by the specified number of commits. Specify "inf" for
> +	infinite depth.
>  
>  ifndef::git-pull[]
>  --dry-run::
> diff --git a/Documentation/git-fetch-pack.txt b/Documentation/git-fetch-pack.txt
> index 4a8487c..75e4669 100644
> --- a/Documentation/git-fetch-pack.txt
> +++ b/Documentation/git-fetch-pack.txt
> @@ -70,6 +70,7 @@ OPTIONS
>  
>  --depth=<n>::
>  	Limit fetching to ancestor-chains not longer than n.
> +	Specify 0 for infinite depth.
>  
Should we force users to remember which one is which?
Show 10 quoted lines
> diff --git a/transport.c b/transport.c
> index cf7030b..9303aef 100644
> --- a/transport.c
> +++ b/transport.c
> @@ -475,7 +475,7 @@ static int set_git_option(struct git_transport_options *opts,
>  			opts->shallow = 0;
>  		}
>  		else {
> -			opts->depth = atoi(value);
> +			opts->depth = !strcmp(value, "inf") ? 0 : atoi(value);
Doesn't atoi("inf") give you 0 anyway ;-)?
Previous: Nguyen Thai Ngoc DuyNext: Junio C Hamano
Message 6 of 8 in “clone: do not accept --depth on local clones”
  1. 1/3 clone: do not accept --depth on local clonesNguyễn Thái Ngọc Duy, Aug 20, 2010
  2. 2/3 fetch-pack: use args.shallow to detect shallow clone instead of args.depthNguyễn Thái Ngọc Duy, Aug 20, 2010
  3. 3/3 {fetch,upload}-pack: allow --depth=0 for infinite depthNguyễn Thái Ngọc Duy, Aug 20, 2010
  4. Jakub NarebskiAug 20, 2010
  5. Nguyen Thai Ngoc DuyAug 22, 2010
  6. Junio C HamanoAug 21, 2010
  7. Junio C HamanoAug 21, 2010
  8. Nguyen Thai Ngoc DuyAug 22, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.