Re: [PATCH] fast-import: add 'ls' command

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 2, 2010, 19:20 UTC
Message-ID: <7vr5e0q8wm.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20101202173722.GE3962@burratino>

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 9 quoted lines

> I somewhat agree.  Actually I would go further: the word "index" brings
> to mind .git/index and its in-core counterpart, so at the same time as
> documenting it better, we might look into making it more self-
> explanatory.  Maybe a syntax like
>
> 	ls current "path/to/entry"
>
> would make it clearer that this is about directory entries in
> fast-import's active commit and not necessarily the usual index file?

I think that explains the feature better. I was wondering if the stream somehow wanted to access the state the index of the repository happens to be.

Show 6 quoted lines

> I am not sure what syntax other vcs-es use for tree-ishes.  To avoid
> name clashes (what if 'current' is the low-level name of a tree-ish?),
> an alternative might be
>
> 	ls-tree :11 "path/to/historical/entry"
> 	ls "path/to/current/entry"

Is it an option to use "ls" for both cases and treat one-arg and two-arg cases differently?