Re: Git Bug - diff in commit message.

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 25, 2011, 14:11 UTC
Message-ID: <7vr52140ve.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CAOeW2eG_muSdbWUaPG36=1-Ay6h6-4qHgWPNdjqY5Zpb52XisQ@mail.gmail.com>

Martin von Zweigbergk <martin.von.zweigbergk@gmail.com> writes:

>> And here is a quick hack to do that using "log --cherry-pick --right-only".
>
> Thanks. I had done something similar. I have now adopted most of your
> changes into my patches, but  I have a few questions.

It was a quick hack and not necessarily well thought out.

> Are these braces needed?

Probably not.

Show 5 quoted lines

> In your previous mail in this thread, this was
> ...
> I see why you dropped "-m --first-parent"; we should simply never
> receive such patches to "git-am --rebasing". But why isn't --binary
> necessary?

It may be; I somehow thought we made it a no-op but didn't check.

> Why was this part left out?

No particular reason other than I was not looking at the earlier "how about this" patch closely. It may be needed, it may not be, I dunno, and I didn't check when I wrote this second quick hack.

Thanks.