git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git-diff-tree does not use alternate objects for submodules

From
Junio C Hamano <gitster@pobox.com>
Date
May 14, 2012, 18:03 UTC
Message-ID
<7vr4umhc7r.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20120514175125.GD58058@book.hvoigt.net>
Heiko Voigt <hvoigt@hvoigt.net> writes:
Show 6 quoted lines
> link_alt_odb_entry() uses realpath to combine relative entries with
> relative_base before recursively passing the entry to
> read_info_alternates().
>
> For entries with absolute path relative_base does not seem to be
> relevant.

I wasn't worried about "entries with absolute paths". I was worried about relative_base that the caller passes may not be absolute but relative to something (perhaps the processe's getcwd()); it seems that the call to real_path() to turn it into an absolute one at the very beginning of the link_alt_odb_entry() function does indeed take care of that case.

Thanks.
Previous: Heiko Voigt
Message 12 of 12 in “git-diff-tree does not use alternate objects for submodules”
  1. Orgad and Raizel ShanehMay 8, 2012
  2. Junio C HamanoMay 8, 2012
  3. Junio C HamanoMay 8, 2012
  4. Heiko VoigtMay 9, 2012
  5. Junio C HamanoMay 9, 2012
  6. Junio C HamanoMay 9, 2012
  7. Heiko VoigtMay 13, 2012
  8. Heiko VoigtMay 13, 2012
  9. teach add_submodule_odb() to look for alternatesHeiko Voigt, May 14, 2012
  10. Junio C HamanoMay 14, 2012
  11. Heiko VoigtMay 14, 2012
  12. Junio C HamanoMay 14, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.