Re: Vietnamese l10n pull request problems

From: Junio C Hamano <gitster@pobox.com>
Date: May 28, 2012, 05:23 UTC
Message-ID: <7vr4u46fr0.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CANYiYbHWsfNSVESsZ6KoSH+_FEuLrrESC1_N0=DB5uMaWSv+Xg@mail.gmail.com>

Jiang Xin <worldhello.net@gmail.com> writes:

Show 6 quoted lines

> Vnwildman, the new git l10n team leader for Vietnamese send me a huge
> pull request, it has some problems I think other l10n teams should care about.
>
> The URL for the pull request is https://github.com/git-l10n/git-po/pull/22 .
>
> 1. Commit log should has a signed-off-by line, no dought

There doesn't seem to have any S-o-b:. Please reject and kick this series back to the team and ask them to redo their history.

> 2. Trival commits (from the same contributor, with not description in
>     commit log) should be squashed or not, I am not sure.

As you noted in 3., there are too many useless merges directly from me, and after remove them, there remain only commits with useless single line subject "Continue translation into Vietnamese." (even for a single-line log message that is wrong; omit the final full-stop).

I think the reason why these have the same useless subject is because they are separate only because the translator happened to have stopped between commits, not because each of these is logically separate and deserves a unique message.

They should all be squashed into a single commit, after removing the merge in the wrong direction.

> 3. l10n team leaders should not merge git upstream directly.

Again, very true.

>>> Oh dear!I hate to change history!

That is not a valid excuse. The history leading to e4797a3bc277 will never be in my tree, and if Jiang pulls it, the I won't be able to pull from him either, so as far as wider upstream git is concerned, the history did not even exist---there is no harm rebuilding a history that never existed in the first place ;-)

Thanks.