Re: [PATCH 6/6] t4012: Make --shortstat more robust

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 11, 2012, 22:35 UTC
Message-ID: <7vr4sic4e7.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20120711221327.GA21382@akuma>

Alexander Strasser <eclipse7@gmx.net> writes:

> The --shortstat test depends on the same scenario as the --stat
> test. Use the part of the same expected result for the --stat test
> to avoid duplicating it manually.

Show 10 quoted lines

> diff --git a/t/t4012-diff-binary.sh b/t/t4012-diff-binary.sh
> index 81a9e8c..a3f6030 100755
> --- a/t/t4012-diff-binary.sh
> +++ b/t/t4012-diff-binary.sh
> @@ -38,9 +38,9 @@ test_expect_success 'apply --stat output for binary file change' '
>  '
>  
>  test_expect_success 'diff --shortstat output for binary file change' '
> -	echo " 4 files changed, 2 insertions(+), 2 deletions(-)" >expected &&
> +	tail -1 expected >expect &&

"(tail|head) -n 1" is preferred. There are the same POSIX.1 violations in a handful of other scripts, 5526, 7502, 7800 and 9146.

Show 6 quoted lines

>  	git diff --shortstat >current &&
> -	test_i18ncmp expected current
> +	test_i18ncmp expect current
>  '
>  
>  test_expect_success 'diff --shortstat output for binary file change only' '

Other than that, the series looked good.  Thanks.