git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 00/21] git p4: work on cygwin

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 28, 2012, 19:17 UTC
Message-ID
<7vr4pmkld7.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1348833865-6093-1-git-send-email-pw@padd.com>
Pete Wyckoff <pw@padd.com> writes:
Show 47 quoted lines
> This series fixes problems in git-p4, and its tests, so that
> git-p4 works on the cygwin platform.
>
> See the wiki for info on how to get started on cygwin:
>
>     https://git.wiki.kernel.org/index.php/GitP4
>
> Testing by people who use cygwin would be appreciated.  It would
> be good to support cygwin more regularly.  Anyone who had time
> to contribute to testing on cygwin, and reporting problems, would
> be welcome.
>
> There's more work requried to support msysgit.  Those patches
> are not in good enough shape to ship out yet, but a lot of what
> is in this series is required for msysgit too.
>
> These patches:
>
>     - fix bugs in git-p4 related to issues found on cygwin
>     - cleanup some ugly code in git-p4 observed in error paths while
>       getting tests to work on cygwin
>     - simplify and refactor code and tests to make cygwin changes easier
>     - handle newline and path issues for cygwin platform
>     - speed up some aspects of git-p4 by removing extra shell invocations
>
> Pete Wyckoff (21):
>   git p4: temp branch name should use / even on windows
>   git p4: remove unused imports
>   git p4: generate better error message for bad depot path
>   git p4: fix error message when "describe -s" fails
>   git p4 test: use client_view to build the initial client
>   git p4 test: use client_view in t9806
>   git p4 test: start p4d inside its db dir
>   git p4 test: translate windows paths for cygwin
>   git p4: remove unreachable windows \r\n conversion code
>   git p4: scrub crlf for utf16 files on windows
>   git p4 test: newline handling
>   git p4 test: use LineEnd unix in windows tests too
>   git p4 test: avoid wildcard * in windows
>   git p4: cygwin p4 client does not mark read-only
>   git p4 test: disable chmod test for cygwin
>   git p4: disable read-only attribute before deleting
>   git p4: avoid shell when mapping users
>   git p4: avoid shell when invoking git rev-list
>   git p4: avoid shell when invoking git config --get-all
>   git p4: avoid shell when calling git config
>   git p4: introduce gitConfigBool

Very nicely done. I was impressed how easy to understand what the problem each patch attempts to solve is and how it should be solved only from the description and the changes apparently matched the description.

I wish patches from everybody looked like these.
Previous: Pete Wyckoff
Message 29 of 29 in “git p4: work on cygwin”
  1. 00/21 git p4: work on cygwinPete Wyckoff, Sep 28, 2012
  2. 01/21 git p4: temp branch name should use / even on windowsPete Wyckoff, Sep 28, 2012
  3. 02/21 git p4: remove unused importsPete Wyckoff, Sep 28, 2012
  4. 03/21 git p4: generate better error message for bad depot pathPete Wyckoff, Sep 28, 2012
  5. Junio C HamanoSep 28, 2012
  6. 04/21 git p4: fix error message when "describe -s" failsPete Wyckoff, Sep 28, 2012
  7. Junio C HamanoSep 28, 2012
  8. 05/21 git p4 test: use client_view to build the initial clientPete Wyckoff, Sep 28, 2012
  9. Junio C HamanoSep 28, 2012
  10. 06/21 git p4 test: use client_view in t9806Pete Wyckoff, Sep 28, 2012
  11. Junio C HamanoSep 28, 2012
  12. Pete WyckoffJan 27, 2013
  13. 07/21 git p4 test: start p4d inside its db dirPete Wyckoff, Sep 28, 2012
  14. 08/21 git p4 test: translate windows paths for cygwinPete Wyckoff, Sep 28, 2012
  15. 09/21 git p4: remove unreachable windows \r\n conversion codePete Wyckoff, Sep 28, 2012
  16. 10/21 git p4: scrub crlf for utf16 files on windowsPete Wyckoff, Sep 28, 2012
  17. 11/21 git p4 test: newline handlingPete Wyckoff, Sep 28, 2012
  18. 12/21 git p4 test: use LineEnd unix in windows tests tooPete Wyckoff, Sep 28, 2012
  19. 13/21 git p4 test: avoid wildcard * in windowsPete Wyckoff, Sep 28, 2012
  20. 14/21 git p4: cygwin p4 client does not mark read-onlyPete Wyckoff, Sep 28, 2012
  21. 15/21 git p4 test: disable chmod test for cygwinPete Wyckoff, Sep 28, 2012
  22. Johannes SixtSep 28, 2012
  23. 16/21 git p4: disable read-only attribute before deletingPete Wyckoff, Sep 28, 2012
  24. 17/21 git p4: avoid shell when mapping usersPete Wyckoff, Sep 28, 2012
  25. 18/21 git p4: avoid shell when invoking git rev-listPete Wyckoff, Sep 28, 2012
  26. 19/21 git p4: avoid shell when invoking git config --get-allPete Wyckoff, Sep 28, 2012
  27. 20/21 git p4: avoid shell when calling git configPete Wyckoff, Sep 28, 2012
  28. 21/21 git p4: introduce gitConfigBoolPete Wyckoff, Sep 28, 2012
  29. Junio C HamanoSep 28, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.