Re: [PATCH v2 0/3] fixup remaining cvsimport tests

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 12, 2013, 06:36 UTC
Message-ID: <7vr4lq9acu.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1357971703-28513-1-git-send-email-chris@rorvick.com>

Chris Rorvick <chris@rorvick.com> writes:

Show 11 quoted lines

> Reroll w/ sign-off.
>
> Chris Rorvick (3):
>   t/lib-cvs.sh: allow cvsps version 3.x.
>   t9600: fixup for new cvsimport
>   t9604: fixup for new cvsimport
>
>  t/lib-cvs.sh                    |  2 +-
>  t/t9600-cvsimport.sh            | 10 ++++------
>  t/t9604-cvsimport-timestamps.sh |  5 ++---
>  3 files changed, 7 insertions(+), 10 deletions(-)

Thanks.

I too noticed the droppage of "-a" support, which may not be a big deal (people can drop it from their script, run cvsimport and they can drop newer commits from the resulting Git history to emulate the old behaviour without "-a" that attempted to find a quiescent point if they really want to and suspect that the upstream CVS repository was not quiescent during the import).

Likewise for "-x". You said "no longer can be told" and that is technically true, but it is more like "no longer need to be told, as stale cache cannot get in the way", so it is probably not a big deal, either, for people to drop it from their script.

About the changed behaviour regarding "origin", I suspect that it is a change for the better, but we would probably need documentation updates to cover it (and deleted options and (mis)features) before this topic graduates.