Re: "git branch --contains x y" creates a branch instead of checking containment

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 21, 2013, 17:48 UTC
Message-ID: <7vr4k9v9r5.fsf@alter.siamese.dyndns.org>
In-Reply-To: <512645D1.4040607@opera.com>

Per Cederqvist <cederp@opera.com> writes:

Show 23 quoted lines

> On 02/21/13 16:58, Jeff King wrote:
>> On Thu, Feb 21, 2013 at 02:00:27PM +0100, Per Cederqvist wrote:
>>
>>> That command does something completely different,
>>> though. The "--contains x" part is silently ignored,
>>> so it creates a branch named "y" pointing at HEAD.
>>>
>>> Tested in git 1.8.1.1 and 1.8.1.4.
>>>
>>> In my opinion, there are two ways to fix this:
>>>
>>>   - change the "git branch" implementation so
>>>     that --contains implies --list.
>>
>> I think that is the best option, too. In fact, I even wrote a patch. :)
>>
>> It's d040350 (branch: let branch filters imply --list, 2013-01-31), and
>> it's already in v1.8.2-rc0.
>>
>> -Peff
>
> Great! Thanks for the quick fix of my bug report. Negative response
> time... not bad. Not bad at all. :-)

Yeah, Jeff has a time machine ;-)