Re: [PATCH v2 1/8] Add new git-cc-cmd helper to contrib
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 19, 2013, 19:56 UTC
- Message-ID
- <7vr4i6z448.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <CAMP44s2gA0JbfxA1UQW_pnizGBpmbQem3Qg0FpWP_Wi6eYwVjw@mail.gmail.com>
Felipe Contreras <felipe.contreras@gmail.com> writes:
Show 8 quoted lines
>> If this were _only_ to be used within send-email (i.e. replacing the >> "then send it out" above with "then use send-email" to limit the >> usecase), "git cc-cmd" would be a reasonable name. But if that is >> the intended use case, it would even be more reasonable to make this >> logic part of send-email and trigger it with --auto-cc-reviewers >> option or something. > > Yeap, but I wouldn't want to be the one that implements that in perl.
That is OK. None of this has to be done by you.
And we seem to be in agreement that the feature deserves to be its own command, so it does not have to be in Perl, either.
Show 7 quoted lines
>> But I think it can be useful outside the context of send-email as >> well, and having one independent tool that does one single job well >> is a better design. Perhaps it is better to name it less specific >> to send-email's cc-cmd option. "git people"? "git whom"? "git >> reviewers"? I dunno, but along those lines. > > 'git relevant'? 'git related'? It's not only people, also commits.
Let's let it simmer on the list for a few days so that other people can come up with a better name.