Re: [PATCH] editor: use canonicalized absolute path
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 29, 2013, 19:40 UTC
- Message-ID
- <7vr4ehyx2j.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <CALkWK0=ZekB9uVtzM_z4wbfZ0JWawaob_PspM9UHbVJKyFGBfw@mail.gmail.com>
Ramkumar Ramachandra <artagnon@gmail.com> writes:
Show 13 quoted lines
> Junio C Hamano wrote: >> Ramkumar Ramachandra <artagnon@gmail.com> writes: >>> Junio C Hamano wrote: >>>> That's a bit strange---the patch text looks like the "how about >>>> this" patch Duy posted earlier. Shouldn't it be From: Duy with >>>> S-o-b: by two of you instead? >>> >>> Feel free to amend as you see fit, as always. >> >> I was asking what is "correct", without which I cannot "feel free" >> to do anything, and your answer is not helping. > > I don't have a strong opinion either way.
There is no opinion involved. Maybe the word "correct" had a wrong connotation, but what I needed to find out was a true provenance of the change, as that is what the S-o-b chain records. I did not know, and I needed to find out, if the patch in question was what you came up independently without looking at Duy's patch (which is very understandable as you two were going back and forth digging the issue on the list), or you submitted his patch after tidying it up.
It appears from your description below that it was an independent work, so that is what I'll queue.
Thanks.
> Fwiw, I posted the original > with me as the author because I discovered it, dug through the emacs > sources for hours to find the exact bug, and contacted emacs-devel > about it.