Re: [PATCH] Fix memory leaks in read_tree_recursive()

From: Junio C Hamano <junkio@cox.net>
Date: May 4, 2005, 23:43 UTC
Message-ID: <7vpsw6muay.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20050504231959.GA25475@diku.dk>

>>>>> "JF" == Jonas Fonseca <fonseca@diku.dk> writes:

JF> This patch fixes memory leaks in the error path of JF> read_tree_recursive().

The leak seems to be real but what is "mem_free"? Has it been compile tested?

JF> @@ -39,14 +39,18 @@
JF>  		if (S_ISDIR(mode)) {
JF>  			int retval;
 
JF> ...
JF> -			if (!eltbuf || strcmp(elttype, "tree"))
JF> +			if (!eltbuf || strcmp(elttype, "tree")) {
JF> +				if (eltbuf) mem_free(eltbuf);
JF>  				return -1;

Btw, who is putting this header in your mail? It does not make sense to me unless Jonas is pseudonym for Linus...

  Mail-Followup-To: Linus Torvalds <torvalds@osdl.org>, git@vger.kernel.org