git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] minor Makefile and local-pull.c edits for Darwin

From
Junio C Hamano <junkio@cox.net>
Date
May 10, 2005, 06:44 UTC
Message-ID
<7vpsvzpolp.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<428038D0.5000706@zytor.com>
>>>>> "HPA" == H Peter Anvin <hpa@zytor.com> writes:

HPA> This is just plain WRONG. st.st_size is longer than long on many HPA> architectures, including Linux/i386.

HPA> The easiest way to deal with it is to #include <inttypes.h>, use %jd HPA> and cast it to (intmax_t). That is, however, a C99-ism.

Actually the easiest way is to stop reporting the size. Nobody else in core GIT reports st.st_size in their error messages.

Although I agree with you that what you say about the size of st.st_size is correct, in GIT world view, apparently "unsigned long" is big enough to hold st.st_size all over the code. Would you recommend tackling that assumption as well?

Previous: H. Peter AnvinNext: H. Peter Anvin
Message 5 of 9 in “minor Makefile and local-pull.c edits for Darwin”
  1. minor Makefile and local-pull.c edits for DarwinMark Allen, May 10, 2005
  2. Daniel BarkalowMay 10, 2005
  3. Junio C HamanoMay 10, 2005
  4. H. Peter AnvinMay 10, 2005
  5. Junio C HamanoMay 10, 2005
  6. H. Peter AnvinMay 10, 2005
  7. H. Peter AnvinMay 10, 2005
  8. Junio C HamanoMay 10, 2005
  9. H. Peter AnvinMay 10, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.