git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Reworked read-tree.

From
Junio C Hamano <junkio@cox.net>
Date
Sep 1, 2005, 07:10 UTC
Message-ID
<7vpsrt1cwc.fsf_-_@assigned-by-dhcp.cox.net>
In-Reply-To
<7vvf1l1env.fsf@assigned-by-dhcp.cox.net>

Daniel, I do not know what your current status is, but I think you need something like this.

I was scratching my head figuring out why it passes all the t/ tests but couldn't do a simple 'git-read-tree HEAD'.

---
diff --git a/tree.c b/tree.c
--- a/tree.c
+++ b/tree.c
@@ -224,10 +224,12 @@ struct tree *parse_tree_indirect(const u
 		if (obj->type == tree_type)
 			return (struct tree *) obj;
 		else if (obj->type == commit_type)
-			return ((struct commit *) obj)->tree;
+			obj = (struct object *)(((struct commit *) obj)->tree);
 		else if (obj->type == tag_type)
-			obj = ((struct tag *) obj)->tagged;
+			obj = deref_tag(obj);
 		else
 			return NULL;
+		if (!obj->parsed)
+			parse_object(obj->sha1);
 	} while (1);
 }
Previous: Junio C HamanoNext: Daniel Barkalow
Message 6 of 7 in “Couple of read-tree questions”
  1. Daniel BarkalowSep 1, 2005
  2. Junio C HamanoSep 1, 2005
  3. Junio C HamanoSep 1, 2005
  4. Daniel BarkalowSep 1, 2005
  5. Junio C HamanoSep 1, 2005
  6. Reworked read-tree.Junio C Hamano, Sep 1, 2005
  7. Daniel BarkalowSep 1, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.