Re: cygwin: t3200-branch.sh fails with "List form of pipe open not implemented at -e line 22."

From: Junio C Hamano <junkio@cox.net>
Date: Oct 14, 2005, 16:09 UTC
Message-ID: <7vpsq8rsgv.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <81b0412b0510140546ya10bc8fg3dd5eaab429eba6f@mail.gmail.com>

Alex Riesen <raa.lkml@gmail.com> writes:

Show 7 quoted lines

> Now, how broken is that:
>
> The message comes from one of the hooks, which are executed even
> though they never meant to, because cygwin apparently uses file
> content or name to detect executability (on FAT).
>
> I just remove the hooks from repositories atm.

Ah, that indeed is broken.

We probably should fix it at two levels.

Unless a test is trying to make sure the hook mechanism works, I think we should not have them in the t/trash/ test repository. The initial git-init-db done at the end of t/test-lib.sh should be changed to run with an explicit --template= parameter to not copy templates from random places. If somebody is going to do this and supply a tested patch to me, it will also be nice to add tests to specifically check the hook mechanism while she is at it.

I think the original idea of using executable bit to control whether the hook is enabled or not is still sound, but it may be safer to have hooks in templates to have a suffix such as .sample in their names *and* be executable --- the set of hooks copied from default templates are still disabled, but now instead of asking users to "chmod +x foo-hook", we ask them to "mv foo-hook.sample foo-hook" if she wants to enable it.