git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: PATCH: Allow format-patch to attach patches

From
Junio C Hamano <junkio@cox.net>
Date
Mar 7, 2006, 01:01 UTC
Message-ID
<7vpskz5aqh.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<440C352C.9070009@codeweavers.com>
Nicely done.

Especially I like the part that you explicitly set charset to UTF-8 to the primary part.

The only two and half minor issues I might have about this are:
 (1) is the type text/x-patch appropriate?
 (2) is it possible to cheaply come up with a safe mime-magic,
     instead of a hardcoded long string and hope it does not
     clash?

You can just say "Yes it is an established practice, widely accepted and that is what you are responding to so obviously you can grok it ;-)" to (1). About (2), you would probably need to read the "diff-tree -p" output beforehand if we want to be absolutely sure, so punting on the issue like this might be the best practical approach for now, but I am asking it anyway because people may have better ideas.

The remaining half issue is if would it make sense to sometimes optionally use non 8-bit CTE for the patch part. I do _NOT_ want to receive CTE=QP patch myself, nor I want to encourage it (actually I would want to actively discourage it), but I do not mind if people find use of such a patch in a distant corner of the galaxy where I do not have to touch such a patch.

Previous: Mike McCormackNext: Mike McCormack
Message 2 of 4 in “PATCH: Allow format-patch to attach patches”
  1. Mike McCormackMar 6, 2006
  2. Junio C HamanoMar 7, 2006
  3. Mike McCormackMar 7, 2006
  4. A Large Angry SCMMar 7, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.