git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] revision: simplify argument parsing.

From
Junio C Hamano <junkio@cox.net>
Date
Apr 3, 2006, 04:22 UTC
Message-ID
<7vpsjzguff.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<443063E2.1040904@lsrfire.ath.cx>
Rene Scharfe <rene.scharfe@lsrfire.ath.cx> writes:
> The comment is misleading because the patch not only moves stuff around,
> it also removes setting of revs->limited when revs->min_age has been
> set.
You are correct that the patch does more than it claims to.

That is an independent fix mentioned in my earlier message <7vr74jxhp3.fsf@assigned-by-dhcp.cox.net>. We did not have to pay the overhead of having to call limit_list() when only min_age was specified because we did not do traversal filtering using UNINTERESTING logic for min_age, but we called it anyway. Unlike --max-age that marks an old one _and_ its parents uninteresting, it needs to filter a young one without making its parents uninteresting.

Previous: Linus Torvalds
Message 17 of 17 in “Move "--parent" parsing into generic revision.c library code”
  1. 1/2 Move "--parent" parsing into generic revision.c library codeLinus Torvalds, Mar 31, 2006
  2. 2/2 Make path-limiting be incremental when possible.Linus Torvalds, Mar 31, 2006
  3. Linus TorvaldsMar 31, 2006
  4. Junio C HamanoMar 31, 2006
  5. Linus TorvaldsMar 31, 2006
  6. Junio C HamanoMar 31, 2006
  7. Linus TorvaldsMar 31, 2006
  8. Junio C HamanoMar 31, 2006
  9. Linus TorvaldsMar 31, 2006
  10. Junio C HamanoMar 31, 2006
  11. Linus TorvaldsApr 2, 2006
  12. Junio C HamanoApr 2, 2006
  13. revision: simplify argument parsing.Junio C Hamano, Apr 2, 2006
  14. revision: --max-age alone does not need limit_list() anymore.Junio C Hamano, Apr 2, 2006
  15. Junio C HamanoMar 31, 2006
  16. Linus TorvaldsMar 31, 2006
  17. Junio C HamanoApr 3, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.