Re: [PATCH 2/2] Add builtin "git rm" command
- From
Junio C Hamano <junkio@cox.net>
- Date
- May 21, 2006, 08:20 UTC
- Message-ID
- <7vpsi7zt53.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <Pine.LNX.4.64.0605191607580.10823@g5.osdl.org>
Linus Torvalds <torvalds@osdl.org> writes:
Show 10 quoted lines
> I think the new behaviour is strictly an improvement, but perhaps more > importantly, it is _different_. As a special case, the semantics are > identical for the single-file case (which is the only one our test-suite > seems to test). > > The other question is what to do with leading directories. The old "git > rm" script didn't do anything, which is somewhat inconsistent. This one > will actually clean up directories that have become empty as a result of > removing the last file, but maybe we want to have a flag to decide the > behaviour?
I too think these are improvements. Thanks for the patch.
BTW, this needed another "evil merge" into "next", so this time I made a separate evil merge branch that I speculated as a possibly better alternative approach in an earlier message.