Re: [PATCH 5/5] fetch: Clean output

From: Junio C Hamano <junkio@cox.net>
Date: Sep 30, 2006, 02:17 UTC
Message-ID: <7vpsdehzcs.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <8764f61r74.fsf@gmail.com>

Santi Béjar <sbejar@gmail.com> writes:

Show 6 quoted lines

> Do not show duplicated remote branch information and reformat the output as:
>
> $ git fetch -v   # the committish lines for the -v.
> * refs/heads/origin: fast forward to remote branch 'master' of ../git/
>   1ad7a06..bc1a580
>   committish: bc1a580

I am not quite sure about this --- it is not obvious what these two numbers represent anymore. Also I think the last line outlived its usefulness (99% of the time refs are committish, so noting exception is good but otherwise it is not interesting).

I know you opted for minimum patch, but it might be a good time to polish the wording a bit while we are touching the general vicinity of the code.

How about saying something like:

 * refs/heads/origin: fast forward to remote branch 'master' of ../git/
   old..new = 1ad7a06..bc1a580

Show 5 quoted lines

> * refs/heads/pu: does not fast forward to remote branch 'pu' of ../git/;
>   7c733a8...5faa935
>   not updating.
>   forcing update.
>   committish: 5faa935

This is even more confusing. Perhaps we would want to have two cases, depending on --force (and +).

 * refs/heads/pu: does not fast forward to remote branch 'pu' of ../git/;
   but forcing update anyway.  old...new = 7c733a8...5faa935

 * refs/heads/pu: does not fast forward to remote branch 'pu' of ../git/;
   not updating.  old...new = 7c733a8...5faa935