Re: [PATCH/RFC 0/8] use "git diff" in the test suite

From: Junio C Hamano <junkio@cox.net>
Date: Feb 25, 2007, 23:11 UTC
Message-ID: <7vps7xrfxa.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.63.0702252329550.22628@wbgn013.biozentrum.uni-wuerzburg.de>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 7 quoted lines

> Now that --no-index is supported by git's diff, we can use much of the 
> test suite to do the job, instead of relying on GNU diff.
>
> This is a bit work-in-progress, since the handling of "-" as a filename is 
> not fleshed out yet, and we really should have the "--quiet" option. But I 
> got side-tracked by the edit-patch-series script, and did not want to hold 
> these patches off any longer.

As you said yourself [6/8], [7/8], and [8/8] are mechanical conversions, and I do not think it is too much effort involved on your side to "hold these patches off".

My preference is to apply [1/8] now, cook the result in 'next' for a few days longer to see if anybody complains or finds glitches in the diff-ni series so far, push it out to 'master' and then apply [2/8] and [3/8] while on 'master'. The remainder would be forked into a topic branch and cooked in 'pu' and then 'next' as usual.

Also I do not think we would necessarily want [7/8] and [8/8]. It would help with tests on broken distributions whose 'cmp' misbehaves when the output is redirected to /dev/null, but I do not think it is a good enough reason to make the tests slower.