Re: [PATCH 6/7] Small changes

From: Junio C Hamano <junkio@cox.net>
Date: Mar 3, 2007, 22:15 UTC
Message-ID: <7vps7q7z44.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <15313.1172917217@localhost>

Xavier Maillard <zedek@gnu.org> writes:

> * Makefile: add git-blame as a candidate to the
>   byte-compilation. Change the function to call to byte-compile.

Could we have a bit more detailed description on the latter change?

Explaining why something needed a change is the point of a commit log message. Summarizing what got changed and how is good but that is secondary, because anybody can see that you changed the handcrafted --eval to -f by running "git show", even if you did not have the above proposed log message.

What is left unsaid is _why_ it is better to use single dash form of "-batch" and -f form instead of handcrafted --eval, and the proposed log message does not clarify the reason.

Show 5 quoted lines

>  %.elc: %.el
> -	$(EMACS) --batch --eval '(byte-compile-file "$<")'
> +	$(EMACS) -batch -f batch-byte-compile $<
>  
>  clean:; rm -f $(ELC)