Re: [PATCH 2/2] Add --ignore-notfound option to exit with zero status when no files are removed.

From: Junio C Hamano <junkio@cox.net>
Date: Apr 16, 2007, 07:59 UTC
Message-ID: <7vps64vjfc.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20070416075324.GA18961@midwinter.com>

Steven Grimm <koreth@midwinter.com> writes:

>  Documentation/git-rm.txt |    3 +++
>  builtin-rm.c             |   21 +++++++++++++++++----
>  t/t3600-rm.sh            |    4 ++++
>  3 files changed, 24 insertions(+), 4 deletions(-)

I find it easier to see what is going on with two independent features separated out, especially with tests. Much nicer.

Show 7 quoted lines

> @@ -47,6 +47,9 @@ OPTIONS
>  	the paths only from the index, leaving working tree
>  	files.
>  
> +\--ignore-notfound::
> +	Exit with a zero status even if no files matched.
> +

ls-files has --error-unmatch so we may want to make the name consistent by saying --ignore-unmatch? I particularly do not care about the minute naming issues _right_ _now_, but we might regret it in the long run.

No need to resend unless you have an actual fix; I'll queue your patch as is in 'pu', wait for a few days for comments on the naming, and amend it as needed.

Thanks.