Re: git-log fatal error in empty repo
"Steve Hoelzer" <shoelzer@gmail.com> writes:
Show 13 quoted lines
> git-log will return a fatal error for an empty repo, like so:
>
> $ git --version
> git version 1.5.2.73.g18bece
> $ mkdir mytest
> $ cd mytest
> $ git-init
> Initialized empty Git repository in .git/
> $ git-log
> fatal: bad default revision 'HEAD'
>
> It would be nice if git-log was quiet or returned a "no log" message
> instead of the fatal error.
Maybe, but I highly doubt if it is worth to bother about it.
revision.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/revision.c b/revision.c
index 0a29b53..0573b86 100644
--- a/revision.c
+++ b/revision.c
@@ -1218,8 +1218,11 @@ int setup_revisions(int argc, const char **argv, struct rev_info *revs, const ch
unsigned char sha1[20];
struct object *object;
unsigned mode;
- if (get_sha1_with_mode(def, sha1, &mode))
+ if (get_sha1_with_mode(def, sha1, &mode)) {
+ if (!strcmp("HEAD", def))
+ die("You have no history yet on your HEAD");
die("bad default revision '%s'", def);
+ }
object = get_reference(revs, def, sha1, 0);
add_pending_object_with_mode(revs, object, def, mode);
}
Junio C Hamano <gitster@pobox.com>