Re: index-pack died on pread

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 27, 2007, 03:43 UTC
Message-ID: <7vps2e5x4y.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <alpine.LFD.0.999.0707260911040.3442@woody.linux-foundation.org>

Linus Torvalds <torvalds@linux-foundation.org> writes:

> I'm not saying that's great programming, but the "git_pread()" that git 
> will use in the absense of a real pread() is actually even *less* of a 
> POSIX pread, since it doesn't even try to save/restore the old position 
> (it knows that git doesn't care).

If you mean the offset associated with fd, we actually do.

The original HP-UX error is confusing, as we ask pread() to transfer 428 bytes and it returns 0 (not returning -1 with EINTR). Return value of zero is understandable, if the starting position is at or after the EOF, but the offset is 123601 and 56k objects packed from git.git repository should be longer than that, so that also sounds implausible.