Re: [PATCH 0/3] git-help -i (info): finishing touches

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 11, 2007, 05:27 UTC
Message-ID: <7vprxdhkch.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <200712110622.51583.chriscool@tuxfamily.org>

Christian Couder <chriscool@tuxfamily.org> writes:

Show 6 quoted lines

> Le lundi 10 décembre 2007, Junio C Hamano a écrit :
>> Junio C Hamano <gitster@pobox.com> writes:
>> > This series attempts to add finishing touches to "git help -i" (info)
>> > support.
>
> It looks like the patch series you talk about was not sent to the list.

Hmph, it appears that there was a misconfiguration on my part to drive send-email. Look into 'next' branch.

Show 15 quoted lines

> In the last patch there is:
>
> diff --git a/help.c b/help.c
> index 9d7ad6f..c96b167 100644
> --- a/help.c
> +++ b/help.c
> @@ -286,6 +286,7 @@ static void show_man_page(const char *git_cmd)
>  static void show_info_page(const char *git_cmd)
>  {
>         const char *page = cmd_to_page(git_cmd);
> +       setenv("INFOPATH", GIT_INFO_PATH, 1);
>         execlp("info", "info", "gitman", page, NULL);
>  }
>
> But I wonder if something like this would be better:

I do not think so, as MANPATH has that funky semantics of "appending the system path where a single colon separates an empty path component from the rest." but I do not think there is anything like that in INFOPATH.