Re: performance problem: "git commit filename"

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 13, 2008, 08:14 UTC
Message-ID: <7vprw6qh02.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <alpine.LNX.1.00.0801130028460.13593@iabervon.org>

Daniel Barkalow <barkalow@iabervon.org> writes:

Show 9 quoted lines

> On Sat, 12 Jan 2008, Linus Torvalds wrote:
>
>> It makes builtin-commit.c use the same logic that "git read-tree -i -m" 
>> does (which is what the old shell script did), and it seems to pass the 
>> test-suite, and it looks pretty obvious.
>
> The only issue I know about with using unpack_trees in C as a replacement 
> for read-tree in shell is that unpack_trees leaves "deletion" index 
> entries in memory which are not written to disk,...

I do not think you have to worry about that one. That "to be deleted" was a Linus invention and he surely remembers it.

write_index() function of course knows about skipping them (they are marked as !ce->ce_mode). I think the patch is safe.