Re: [PATCH] git.el: find the git-status buffer whatever its name is

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 28, 2008, 20:14 UTC
Message-ID: <7vprugj0t2.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <87skzd44qn.dlv@maison.homelinux.org>

Remi Vanicat <vanicat@debian.org> writes:

> Any comment on this bug fix ? It seem it was forgotten.
> I re-include it for convenience:

It is very cumbersome to apply if you "include everything inside", so please don't do this.

Instead, send as if it is a new patch, adding Acked-by: by Alexandre after your Signed-off-by: line.

Show 31 quoted lines

> From 8ab57162a69c178dbc04bc4f94271e36ee9d120a Mon Sep 17 00:00:00 2001
> From: Rémi Vanicat <vanicat@debian.org>
> Date: Fri, 22 Feb 2008 22:36:23 +0100
> Subject: [PATCH] git.el: find the git-status buffer whatever its name is
>
> git-status used the buffer name to find git-status buffers, and that
> could failed if the buffer had another name, for example when multiple
> working directories was tracked.
> ---
>  contrib/emacs/git.el |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/contrib/emacs/git.el b/contrib/emacs/git.el
> index f69b697..14a1601 100644
> --- a/contrib/emacs/git.el
> +++ b/contrib/emacs/git.el
> @@ -1545,7 +1545,7 @@ Commands:
>          (with-current-buffer buffer
>            (when (and list-buffers-directory
>                       (string-equal fulldir (expand-file-name list-buffers-directory))
> -                     (string-match "\\*git-status\\*$" (buffer-name buffer)))
> +		     (eq major-mode 'git-status-mode))
>              (setq found buffer))))
>        (setq list (cdr list)))
>      found))
> -- 
> 1.5.4.2.191.g7b407
>
>
> -- 
> Rémi Vanicat