Re: [PATCH] git-quiltimport: better parser to grok "enhanced" series files.

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 9, 2008, 10:17 UTC
Message-ID: <7vpru4p5g1.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20080309095918.GA23924@artemis.madism.org>

Pierre Habouzit <madcoder@debian.org> writes:

Show 5 quoted lines

>> You made the loop a subshell but I think you can redirect into the while
>> loop without an extra "cat" process.
>
> Well probably yeah, I could use an exec -- < series or an alike trick
> for sure.

It seems many people forget that it is perfectly fine to redirect into while loop itself, like

	while read foo bar
        do
        	do a lot of stuff
	done <input-file

Show 11 quoted lines

>> Can a patch name contain $IFS whitespace characters?
>
>   I tested and quilt says that:
>
> $ quilt new a\ b.patch
> Patch a is now on top
>
> And when I quilt refresh it, it creates a patch named 'a'.  (and yes, I thought
> of this and tested it prior to sending the patch).
>
>> If so, this patch would regress them.  Otherwise it looks fine.

Ok, somehow in an earlier patch to quiltimport I picked up an incorrect notion that they could contain a blank, but then that's fine.

Will queue, but I am very well into my merge binge for tonight (and it hasn't finished even though it is past 3 AM, sheesh), so it will be in the next round.