Re: [PATCH 3/3 v2] Make "git-remote rm" delete refs acccording to fetch specs

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 1, 2008, 05:29 UTC
Message-ID: <7vprr1d8p2.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20080601042804.GA32293@spearce.org>

"Shawn O. Pearce" <spearce@spearce.org> writes:

>  This is a longer, but better version of this patch.  Instead of
>  blindly deleting the refs we remove them only if this is the last
>  remote that would write to the local tracking ref.

If this is a better version than the previous one, then probably "git remote prune" patch to unconditionally remove ones that do not exist in one of the remotes that fetch into the tracking namespace also needs to be rethought, doesn't it? Another remote may still have it but you obviously do not know that until you check.

Admittedly, next fetch from the other remote may or may not resurrect them and either way it is not a big deal.

I think this is exactly the same issue as this improvement in [3/3] deals with. If "git remote rm" of one remote removed the shared tracked refs, next fetch from the other remote would resurrect them if the other remote still exists. It may probably feel better to be extra careful like this improved patch, but I doubt it would matter in practice. After all, people who creates such a configuration would know what they are doing.