git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-shell needs $(COMPAT_OBJS)

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 20, 2008, 22:38 UTC
Message-ID
<7vprp82nb6.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<alpine.DEB.1.00.0807210034050.3305@eeepc-johanness>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 9 quoted lines
> On Sun, 20 Jul 2008, Junio C Hamano wrote:
>
>> Why do we care about the size of git-shell so much in the first place 
>> anyway to begin with?
>
> It was not me who proposed it, but I guess it was for auditing purposes: 
> git-shell is often the only point of entry for certain untrusted ssh 
> users, and the less code is linked, the less code has to be analyzed for 
> reachability (and then for security holes).
That's a rather misguided approach, isn't it?

After all, the work requested by the end user will be handled by code in the main git executable by spawning a subprocess, and you are auditing the codepath that leads to the spawning anyway.

Previous: Johannes SchindelinNext: Miklos Vajna
Message 5 of 8 in “git-shell needs $(COMPAT_OBJS)”
  1. git-shell needs $(COMPAT_OBJS)Johannes Sixt, Jul 20, 2008
  2. Johannes SixtJul 20, 2008
  3. Junio C HamanoJul 20, 2008
  4. Johannes SchindelinJul 20, 2008
  5. Junio C HamanoJul 20, 2008
  6. Miklos VajnaJul 20, 2008
  7. Junio C HamanoJul 20, 2008
  8. Junio C HamanoJul 20, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.