Re: [PATCH 2/8] builtin-merge.c: call exclude_cmds() correctly.

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 26, 2009, 05:36 UTC
Message-ID: <7vpr75hmpq.fsf@alter.siamese.dyndns.org>
In-Reply-To: <905749faf5ccb2c7c54d3318dbc662d69daf8d0e.1259201377.git.apenwarr@gmail.com>

"Avery Pennarun" <apenwarr@gmail.com> writes:

> We need to call exclude_cmds() after the loop, not during the loop, because
> excluding a command from the array can change the indexes of objects in the
> array.  The result is that, depending on file ordering, some commands
> weren't excluded as they should have been.

As an independent bugfix, I would prefer this to be made against 'maint' and not as a part of this series.

How did you notice it? Can you make a test case out of your experience of noticing this bug in the first place, by the way (I am suspecting that you saw some breakage and chased it in the debugger)?