Re: [PATCH 2/2] Documentation/remote-helpers: Fix some typos

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 5, 2010, 22:03 UTC
Message-ID: <7vpr2dmu9y.fsf@alter.siamese.dyndns.org>
In-Reply-To: <f3271551003281104h9b672abk1a8ecccd7a4f8964@mail.gmail.com>

Ramkumar Ramachandra <artagnon@gmail.com> writes:

Show 10 quoted lines

> @@ -128,9 +131,9 @@ Supported if the helper has the "import" capability.
>  Supported if the helper has the "connect" capability.
>
>  If a fatal error occurs, the program writes the error message to
> -stderr and exits. The caller should expect that a suitable error
> -message has been printed if the child closes the connection without
> -completing a valid response for the current command.
> +stderr and exits. The caller should expect a suitable error
> +if the child closes the connection without
> +giving a valid response for the current command.

This not just fixes typo but changes what is being said, doesn't it? The point of the original about the "error" is that the caller does not have to issue a redundant error message when the helper closes the connection without reporting the status back, but that information which probably is critical when maintaining the caller (and writing a new callee) is lost.

Other parts looked Ok to me.

Thanks.