Re: [PATCH 2/2] builtin/symbolic-ref.c: add option to output shortened ref
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 27, 2012, 23:04 UTC
- Message-ID
- <7vpqcz514d.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <4F4C07AD.3050404@jk.gs>
Jan Krüger <jk@jk.gs> writes:
Show 11 quoted lines
> On 02/27/2012 11:28 PM, Junio C Hamano wrote: >> I think this one (unlike 1/2) makes sense, but a single letter -s feels a >> bit too vague. Always spelling in long option "--short" so that it >> matches "%(refname:short)" in for-each-ref might be better, I would think. >> >> Especially given that the expected use case is primarily in scripts not >> from the command line, being more explicit and easier to read has value >> over being short and easier to (mis)type. > > Good point. If we can agree on what to do with the first patch, I'll > change that in the next iteration.
Dropping the first patch would be my preference. I do not think this change deserves to be taken hostage to it.