git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitweb(1) Fixed English issues

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 23, 2012, 18:19 UTC
Message-ID
<7vpqc3tc1n.fsf@alter.siamese.dyndns.org>
In-Reply-To
<878vircoby.fsf@thomas.inf.ethz.ch>
Thomas Rast <trast@student.ethz.ch> writes:
Show 29 quoted lines
> Note that the correct way to put commentary in the patch mail that does
> not go into the commit message is putting it after the --- marker.
> Also, we write commit messages in the imperative.  The above should
> probably look roughly like
>
>   Subject: Documentation/gitweb: trivial English fixes
>
>   Change "it's" to "its" where a possessive is intended.
>
>   Also add two missing "the" that were noticed by Ben Walton
>   <bwalton@artsci.utoronto.ca>.
>
>   Signed-off-by: David Waitzman <djw@bbn.com>
>   ---
>   This is a trivial patch to correct the english in the man page.  Ben
>   Walton suggested an additional english fix which I have added and
>   squashed with my change.  And then I added it again when he pointed
>   out I missed something in his original email.
>
>    Documentation/gitweb.txt |    4 ++--
>    1 file changed, 2 insertions(+), 2 deletions(-)
>
>   diff --git a/Documentation/gitweb.txt b/Documentation/gitweb.txt
>   index 605a085..168e8bf 100644
>
> Note that I added "Subject:" here to make it an inline patch (though you
> obviously need to remove my extra formatting indent).  If there's no
> Subject pseudoheader, the patch gets the subject of your email, and
> similarly for From and author.
Thanks.  I'll use this with the patch text you are responding to.
Previous: Thomas Rast
Message 7 of 7 in “gitweb(1): Fixed improper use of "it's" when it should be "its"”
  1. gitweb(1): Fixed improper use of "it's" when it should be "its"David Waitzman, Mar 23, 2012
  2. Ben WaltonMar 23, 2012
  3. gitweb(1) Fixed English issuesDavid Waitzman, Mar 23, 2012
  4. Ben WaltonMar 23, 2012
  5. gitweb(1) Fixed English issuesD Waitzman, Mar 23, 2012
  6. Thomas RastMar 23, 2012
  7. Junio C HamanoMar 23, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.