git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] refs: disallow ref components starting with hyphen

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 16, 2012, 17:49 UTC
Message-ID
<7vpq7v38bd.fsf@alter.siamese.dyndns.org>
In-Reply-To
<7v7gu34ow0.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
Show 10 quoted lines
> Michael Schubert <mschub@elegosoft.com> writes:
>
>> Currently, we allow refname components to start with a hyphen. There's
>> no good reason to do so...
>
> That is way too weak as a justification to potentially break
> existing repositories.
>
> Refusal upon attempted creation is probably OK, which is why the two
> checks you removed in your patches are fine.

Just to clarify, I meant that the existing checks were OK because they were meant to prevent creation. I didn't mean removal of them was OK.

Previous: Junio C HamanoNext: Michael Schubert
Message 5 of 8 in “refname format cleanup”
  1. refname format cleanupMichael Schubert, Jul 16, 2012
  2. 1/2 refs: disallow ref components starting with hyphenMichael Schubert, Jul 16, 2012
  3. Michael HaggertyJul 16, 2012
  4. Junio C HamanoJul 16, 2012
  5. Junio C HamanoJul 16, 2012
  6. 2/2 symbolic-ref: check format of given refnameMichael Schubert, Jul 16, 2012
  7. Michael HaggertyJul 16, 2012
  8. Junio C HamanoJul 16, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.