git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/5] git p4: fix branch detection with --use-client-spec

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 12, 2012, 19:30 UTC
Message-ID
<7vpq6vgb66.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20120812140449.GA5635@padd.com>
Pete Wyckoff <pw@padd.com> writes:
Show 15 quoted lines
>> The description for [PATCH 5/5] blames v1.7.9-rc0~4^2~1, which tells
>> me it is the latter.  And if that were the case, and if this were in
>> the area of the system I oversee, I wouldn't push it to the upcoming
>> release at this late in the cycle, when I do not know what other
>> things it might break while fixing this bug (in other words, a fix
>> to an old bug is not an execuse to introduce a regression).
>> 
>> But git-p4 is not in my area, so if you meant this should go in the
>> upcoming 1.7.12 release, I'll queue them directly on 'master'.
>> 
>> Please tell me what your preference is.
>
> Good point about "already released bugs".  I confirmed it was
> broken in 1.7.11 too, so there's no reason to rush this fix into
> 1.7.12.  If you could queue it up in pu, that would be great.

OK, I've done so already last night when I wrote my message but haven't pushed the result out yet.

Note (primarily to other people) that the above exchange does not mean "a fix to an old bug is automatically disqualified during the rc freeze period". If the fix is so focused and obvious that there is no way the change inadvertently and negatively affects other code and introduce a new bug, it is perfectly fine to apply the fix any time. I don't know git-p4 well enough to tell if this five patch series was in that "obviously safe" category myself, so I asked Pete to decide it for me.

Thanks.
Previous: Pete Wyckoff
Message 10 of 10 in “git-p4 migrates perforce “main” branch into git branches as subdirectories (doubled code in git branches)”
  1. Matthew KorichAug 10, 2012
  2. 0/5 git p4: fix branch detection with --use-client-specPete Wyckoff, Aug 11, 2012
  3. 1/5 git p4 test: move client_view() function to libraryPete Wyckoff, Aug 11, 2012
  4. 2/5 git p4 test: add broken --use-client-spec --detect-branches testsPete Wyckoff, Aug 11, 2012
  5. 3/5 git p4: set self.branchPrefixes in initializationPete Wyckoff, Aug 11, 2012
  6. 4/5 git p4: do wildcard decoding in stripRepoPathPete Wyckoff, Aug 11, 2012
  7. 5/5 git p4: make branch detection work with --use-client-specPete Wyckoff, Aug 11, 2012
  8. Junio C HamanoAug 12, 2012
  9. Pete WyckoffAug 12, 2012
  10. Junio C HamanoAug 12, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.