Re: [PATCH 1/2] Make lock local to fetch_pack

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 15, 2012, 19:31 UTC
Message-ID: <7vpq2bru28.fsf@alter.siamese.dyndns.org>
In-Reply-To: <7vtxrnrwer.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 13 quoted lines

> Matt Kraai <kraai@ftbfs.org> writes:
>
>> From: Matt Kraai <matt.kraai@amo.abbott.com>
>>
>> lock is only used by fetch_pack, so move it into that function.
>>
>> Signed-off-by: Matt Kraai <matt.kraai@amo.abbott.com>
>> ---
>>  fetch-pack.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> Eh, did you base your patch on something older than 2d4177c (Make
> fetch-pack a builtin with an internal API, 2007-09-10)???

Ah, nevermind. I see we refactored this out recently but that is still in flight.