Re: [PATCH] t6131 - skip tests if on case-insensitive file system

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 17, 2013, 19:47 UTC
Message-ID: <7vppuh55pb.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CACsJy8Ayyb7kTydXFxoeqNQgGemdUXXzAc3ZwEbT5dCuk_tkQA@mail.gmail.com>

Duy Nguyen <pclouds@gmail.com> writes:

Show 8 quoted lines

> On Wed, Jul 17, 2013 at 8:22 PM, Mark Levedahl <mlevedahl@gmail.com> wrote:
>> This test fails on Cygwin where the default system configuration does not
>> support case sensitivity (only case retention), so don't run the test on
>> such systems.
>
> Yeah. I knew this when I wrote this test but forgot to put the check
> in. Thanks. We can re-enable the test later, as it does not really
> need case-insensitive filesystems.

Yeah, I tend to agree. You do not need to create case-colliding paths for the purpose of :(icase) tests.

Show 33 quoted lines

>
>>
>> Signed-off-by: Mark Levedahl <mlevedahl@gmail.com>
>> ---
>>  t/t6131-pathspec-icase.sh | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/t/t6131-pathspec-icase.sh b/t/t6131-pathspec-icase.sh
>> index 3215eef..8d4a7fc 100755
>> --- a/t/t6131-pathspec-icase.sh
>> +++ b/t/t6131-pathspec-icase.sh
>> @@ -3,6 +3,12 @@
>>  test_description='test case insensitive pathspec limiting'
>>  . ./test-lib.sh
>>
>> +if test_have_prereq CASE_INSENSITIVE_FS
>> +then
>> +       skip_all='skipping case sensitive tests - case insensitive file system'
>> +       test_done
>> +fi
>> +
>>  test_expect_success 'create commits with glob characters' '
>>         test_commit bar bar &&
>>         test_commit bAr bAr &&
>> --
>> 1.8.3.2.0.63
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe git" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> Duy