Re: [PATCH 5/5] git-daemon support for user-relative paths.

From: Junio C Hamano <junkio@cox.net>
Date: Nov 18, 2005, 00:49 UTC
Message-ID: <7voe4ird8v.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20051117193714.428785C7FA@nox.op5.se>

exon@op5.se (Andreas Ericsson) writes:

> Everything that worked earlier still works insofar as I have
> remembered testing it.

Hmph...

> @@ -152,45 +140,17 @@ static int set_dir(const char *dir)
>  	 * We want a readable HEAD, usable "objects" directory, and
>  	 * a "git-daemon-export-ok" flag that says that the other side
>  	 * is ok with us doing this.

Well, not anymore about HEAD as far as I can tell... Maybe in enter_repo ([PATCH 1/5]) we need to do something like what setup.c::is_toplevel_directory() does?

> -static int upload(char *dir)
> -{
> -	/* Try paths in this order */
> -	static const char *paths[] = { "%s", "%s/.git", "%s.git", "%s.git/.git", NULL };

I think this list was added relatively recently as a usability measure. Maybe we would want an equivalent in enter_repo()? Under strict-path, I think not doing any DWIM like this is fine, but otherwise I suspect changing this would break existing remotes/origin file people may have. In addition enter_repo() as posted does its own DWIM to chdir to ".git" unconditionally as I pointed out...

Needs a bit more thought, but I think otherwise the basic idea is right.