Re: [PATCH] Provide configurable UI font for gitk

From: Junio C Hamano <junkio@cox.net>
Date: Apr 2, 2006, 10:57 UTC
Message-ID: <7vodzkkzxr.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <1143969814.2303.71.camel@neko.keithp.com>

Keith Packard <keithp@keithp.com> writes:

Show 6 quoted lines

> This makes the font used in the UI elements of gitk configurable in the
> same way the other fonts are. The default fonts used in the Xft build of
> tk8.5 are particularily horrific, making this change more important
> there.
>
> Signed-off-by: Keith Packard <keithp@neko.keithp.com>

Thanks for the patch. I haven't run it, but a quick eyeballing suggests what you did is sane. However,..

>  proc makewindow {rargs} {
> -    global canv canv2 canv3 linespc charspc ctext cflist textfont
> +    global canv canv2 canv3 linespc charspc ctext cflist textfont
> mainfont uifont

Your MUA seems to be line-wrapping the patch here and there...

Show 11 quoted lines

> @@ -345,16 +345,20 @@ proc makewindow {rargs} {
>  
>      menu .bar
>      .bar add cascade -label "File" -menu .bar.file
> +    .bar configure -font $uifont
>      menu .bar.file
>      .bar.file add command -label "Update" -command [list updatecommits
> $rargs]
>      .bar.file add command -label "Reread references" -command
> rereadrefs
>...

so the patch does not apply X-<.

Also, I prefer changes to gitk to be fed via Paul Mackerras tree. If you send changes to gitk to me, I will forward patches with my Acked-by: to him and wait for him to bounce the change back to me through his tree, so it is not a big deal for me, and the changes will _not_ be lost anyway, but I'd still appreciate gitk patches to be sent to Paul first if possible.