Re: GIT_OBJECT_DIRECTORY
- From
Junio C Hamano <junkio@cox.net>
- Date
- Apr 19, 2006, 05:00 UTC
- Message-ID
- <7vodyyb1mc.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <4445C1D6.3070504@zytor.com>
"H. Peter Anvin" <hpa@zytor.com> writes:
Show 8 quoted lines
> Jörn Engel wrote: >> >> Excellent! I have a faint memory of hpa recently saying that the git >> daemon would be too resource-hungry. One of the cases where being >> wrong is a Good Thing. > > Well, we ended up making some tweaks to the git daemon, and it hasn't > been a problem since.
Ah, I am glad the daemon expert was listening... Do you have comments on recent patch from Serge E. Hallyn? It looks OK to me, but that standalone daemon part is not something I run myself, so...
-- >8 -- [PATCH] socksetup: don't return on set_reuse_addr() error
The set_reuse_addr() error case was the only error case in socklist() where we returned rather than continued. Not sure why. Either we must free the socklist, or continue. This patch continues on error.
Signed-off-by: Serge E. Hallyn <serue@us.ibm.com> Signed-off-by: Junio C Hamano <junkio@cox.net>
---
daemon.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
0032d548db56eac9ea09b4ba05843365f6325b85
diff --git a/daemon.c b/daemon.c index a1ccda3..776749e 100644 --- a/daemon.c +++ b/daemon.c @@ -535,7 +535,7 @@ #endif if (set_reuse_addr(sockfd)) { close(sockfd); - return 0; /* not fatal */ + continue; } if (bind(sockfd, ai->ai_addr, ai->ai_addrlen) < 0) {
-- 1.3.0.rc4.g5247-dirty