Re: [PATCH] Fix tracing when GIT_TRACE is set to an empty string.

From: Junio C Hamano <junkio@cox.net>
Date: Oct 14, 2006, 18:11 UTC
Message-ID: <7vodseahty.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20061014160525.c013e6d2.chriscool@tuxfamily.org>

Christian Couder <chriscool@tuxfamily.org> writes:

Show 21 quoted lines

> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
> ---
>  trace.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/trace.c b/trace.c
> index f9efc91..495e5ed 100644
> --- a/trace.c
> +++ b/trace.c
> @@ -55,7 +55,8 @@ static int get_trace_fd(int *need_close)
>  {
>  	char *trace = getenv("GIT_TRACE");
>  
> -	if (!trace || !strcmp(trace, "0") || !strcasecmp(trace, "false"))
> +	if (!trace || !strcmp(trace, "") ||
> +	    !strcmp(trace, "0") || !strcasecmp(trace, "false"))
>  		return 0;
>  	if (!strcmp(trace, "1") || !strcasecmp(trace, "true"))
>  		return STDERR_FILENO;
> -- 
> 1.4.3.rc2.gadba

This means that

	GIT_TRACE= git-foo
and
	unset GIT_TRACE ; git-foo

should behave the same way, right?

If so that sounds sensible.