Re: [PATCH] Make gc a builtin.

From: Junio C Hamano <junkio@cox.net>
Date: Mar 14, 2007, 09:29 UTC
Message-ID: <7vodmwcgvc.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <8aa486160703140055s2b03c2aeu1c85dedac59b664b@mail.gmail.com>

"Santi Béjar" <sbejar@gmail.com> writes:

Show 20 quoted lines

> On 3/14/07, Theodore Tso <tytso@mit.edu> wrote:
>> On Wed, Mar 14, 2007 at 12:19:07AM -0700, Junio C Hamano wrote:
>> > >> -test "true" != "$pack_refs" ||
>> > >> -git-pack-refs --prune &&
>> > >> -git-reflog expire --all &&
>> > >> -git-repack -a -d -l &&
>> > >> ...
>> >
>> > I do not necessarily think so.  This is not even a performance
>> > critical part of the system, so if there _were_ no other
>> > constraints, I would rather keep scripts like this as scripts.
>>
>> I agree with Junio; I think the scripts are much more readable and
>> easier to understand; In fact, it would be nice if the script were
>> preserved somewhere, perhaps as comments in the .c file.
>>
>
> Or move them to contrib/examples, as was done with git-resolve.sh.
>
> Santi

That probably is a sensible thing to do.  I'll amend the patch.