Re: Rebase max-pack-size?

From: Junio C Hamano <junkio@cox.net>
Date: May 23, 2007, 07:23 UTC
Message-ID: <7vodkc3swx.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <56b7f5510705222333l6e285e67l1dc327322a2ab250@mail.gmail.com>

"Dana How" <danahow@gmail.com> writes:

Show 15 quoted lines

> Patch 1:
> * Pull "sha1flush()" or similar out of sha1close() inside csum-file.c.
>  This will require some edits to callers.
>
> Patch 2:
> * Add a comment to "confusing loop" to explain what it's checking.
> * Complain about --stdout && --max-pack-size combination.
>
> This will have to happen tomorrow.
>
>> And I have to agree with Linus; responding this way was more
>> cumbersome than it should have been.
> Understood.
>
> Thanks,

Although I mentioned it, as we have only one caller that does not want to close the file, we probably do not need the first patch right now.

Also thanks for the clarification on the (nr_result != nr_objects) stuff -- it should have been obvious, as I was the guilty party who originally introduced that condition (i.e. "thin" packs).