Re: [PATCH] Allow git-instaweb to be run from bare repositories

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 2, 2007, 19:11 UTC
Message-ID: <7vodec31k0.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20071102090922.GA10141@diku.dk>

Jonas Fonseca <fonseca@diku.dk> writes:

Show 21 quoted lines

> Signed-off-by: Jonas Fonseca <fonseca@diku.dk>
> ---
>  git-instaweb.sh |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
>  On IRC yesterday, two were asking for this and it seems simply enough.
>  Apparently, git-instaweb is a great way to see if you've set up a
>  remote repository correctly.
>
> diff --git a/git-instaweb.sh b/git-instaweb.sh
> index 95c3e5a..14917ac 100755
> --- a/git-instaweb.sh
> +++ b/git-instaweb.sh
> @@ -6,6 +6,7 @@ USAGE='[--start] [--stop] [--restart]
>    [--local] [--httpd=<httpd>] [--port=<port>] [--browser=<browser>]
>    [--module-path=<path> (for Apache2 only)]'
>  
> +SUBDIRECTORY_OK=Yes
>  . git-sh-setup
>  
>  fqgitdir="$GIT_DIR"

I'd agree with the goal of the patch, and I would not doubt the patch worked for you, but it somewhat feels wrong that you can say "It is Ok to run this script from a subdirectory" and that is the magic to allow something to work in a bare repository.

Care to share your insights on what is going on?